Skip to content

Update input panel on preedit clearing #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

lo48576
Copy link
Contributor

@lo48576 lo48576 commented Apr 12, 2025

In some cases, input panel does not disappear even when it should.
To reproduce:

  1. Switch to Hiragana mode
  2. Put something to preedit.
    • For example, type k y to put ky to preedit.
  3. Switch to another mode.
    • For example, type l (set-input-mode-latin command in hiragana mode) to switch to Latin mode.
  4. Now you see the floating window (with ky for example) even though the current input mode is Latin.
    • Even worse, this does not disappear until you fill preedit with another content or change the window focus.

The patch solves this issue by updating input panel (floating window) when the input mode is changed and the preedit is cleared.

@wengxt wengxt merged commit 3a7c69b into fcitx:master Apr 30, 2025
3 checks passed
@lo48576 lo48576 deleted the fix/libskk-preedit-on-mode-change branch May 2, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants