Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp: use statusline when initializing #2422

Merged
merged 3 commits into from
Jul 25, 2019

Conversation

bhcleek
Copy link
Collaborator

@bhcleek bhcleek commented Jul 25, 2019

statusline: support initialization messages

Treat initialization messages the same as started and analyzing
messages.

Small refactors for clarity and cleanliness.

lsp: refactor notifications about initialization
  • Only echo gopls initialization progress messages when
    g:go_echo_progress is set.
  • Use the statusline to notify users about gopls initialization
    progress.
lsp: call textDocument/didOpen less often

Only call go#lsp#DidOpen in go#lsp#DidChange if the file is actually
readable.

bhcleek added 3 commits July 24, 2019 22:06
Treat initialization messages the same as started and analysing
messages.

Small refactors for clarity and cleanliness.
* Only echo gopls initialization progress messages when
  g:go_echo_progress is set.
* Use the statusline to notify users about gopls initialization
  progress.
Only call go#lsp#DidOpen in go#lsp#DidChange if the file is actually
readable.
@bhcleek bhcleek merged commit 24b81e8 into fatih:master Jul 25, 2019
@bhcleek bhcleek deleted the lsp/statusline/initialization branch July 25, 2019 05:28
bhcleek added a commit that referenced this pull request Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant