toggle whether term closes #2409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dont mind at all.
…On Sat, Jul 20, 2019 at 11:49 AM Billie Cleek ***@***.***> wrote:
***@***.**** commented on this pull request.
Thanks for the contribution, @ldelossa <https://github.com/ldelossa> . I
only have a couple of small nits. Do you mind if I push some commits to
your branch before merging?
------------------------------
In autoload/go/config.vim
<#2409 (comment)>:
> @@ -47,6 +47,21 @@ function! go#config#TermMode() abort
return get(g:, 'go_term_mode', 'vsplit')
endfunction
+function! go#config#TermExit() abort
+ return get(g:, 'go_term_exit', 1)
+endfunction
+
+function! go#config#ToggleTermExit() abort
+ let l:cur = get(g:, 'go_term_exit', 0)
+ if l:cur == 0
+ silent! unlet g:go_term_exit
+ let g:go_term_exit = 1
+ else
+ silent! unlet g:go_term_exit
+ let g:go_term_exit = 0
There's no need to set it again; unlet will suffice just fine.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2409?email_source=notifications&email_token=ABLBVFUDBZY3WPCKGPCGBG3QAMXZVA5CNFSM4IEQXQU2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7B7UPA#pullrequestreview-264501820>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABLBVFSQ6BVU4NSRNEPRPRDQAMXZVANCNFSM4IEQXQUQ>
.
|
* Rename g:go_term_exit to g:go_term_close_on_exit. * Move the toggle function to autoload/go/term.vim and also refactor it (both for consistency with other option toggling functions). * Add documentation of g:go_term_close_on_exit.
|
@ldelossa I'm not a heavy Neovim user. Would you mind testing my changes to make sure they work for you as you'd expect? |
|
@bhcleek confirmed working. Thanks!! |
bhcleek
added a commit
that referenced
this pull request
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a way to quickly toggle whether the nvim terminal is closed after a quickfix menu is populated.
I found this helpful when needing to add
log.Printf()statements in my tests as the term formatter function does not capture stdout.I am open to discussion here.