Fix breaking non-modifiable buffers in some cases #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhcleek
reviewed
Dec 22, 2018
autoload/go/template.vim
Outdated
| @@ -5,6 +5,9 @@ set cpo&vim | |||
| let s:current_file = expand("<sfile>") | |||
|
|
|||
| function! go#template#create() abort | |||
| if !&modifiable | |||
| return | |||
| endif | |||
There was a problem hiding this comment.
Given that this function does not write the file, why is this change necessary?
There was a problem hiding this comment.
Added some clarification on related issue; but maybe the check should be somewhere else in the call stack?
There was a problem hiding this comment.
Instead of returning early here, it's may be better to return early in https://github.com/fatih/vim-go/blob/master/plugin/go.vim#L278-L283
There was a problem hiding this comment.
Done. Opted for an additional check instead of early return since I felt it was still clear given the var name and context, but please let me know if you'd still prefer it as an early return.
bhcleek
reviewed
Dec 24, 2018
bhcleek
added a commit
that referenced
this pull request
Dec 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2096