don't spam users when Vim is started with Vi compatibility mode #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhcleek
added a commit
that referenced
this pull request
Nov 16, 2018
dhduvall
added a commit
to dhduvall/vim-go
that referenced
this pull request
Dec 11, 2018
If a script calls `finish`, the restoration of `&cpo`, which is at the end of the script, never gets called. As a follow-up to fatih#2055, this change moves the place where `&cpo` is preserved until after the places where `finish` is called. I believe this is safe, since those places are near the beginning of their respective scripts, and there's nothing earlier that's dependent on the default setting of `&cpo`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1982