Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package keyify's repository location #1924

Merged
merged 1 commit into from
Aug 23, 2018
Merged

Update package keyify's repository location #1924

merged 1 commit into from
Aug 23, 2018

Conversation

jtr860830
Copy link
Contributor

github.com/dominikh/go-tools/cmd/keyify -> honnef.co/go/tools/cmd/keyify

github.com/dominikh/go-tools/cmd/keyify -> honnef.co/go/tools/cmd/keyify
@arp242
Copy link
Contributor

arp242 commented Aug 23, 2018

Does it matter? They both seem to work equally well?

@jtr860830
Copy link
Contributor Author

jtr860830 commented Aug 23, 2018

@Carpetsmoker
Yes they work well, but when using :GoUpdateBinaries vim-go will install all go-tools repository and then using

  • go get -u all
  • go get -u github.com/dominikh/go-tools/...

will cause these error:

package github.com/dominikh/go-tools/gcsizes: code in directory $GOPATH/src/github.com/dominikh/go-tools/gcsizes expects import "honnef.co/go/tools/gcsizes"
package github.com/dominikh/go-tools/lint: code in directory $GOPATH/src/github.com/dominikh/go-tools/lint expects import "honnef.co/go/tools/lint"
package github.com/dominikh/go-tools/lint/lintutil: code in directory $GOPATH/src/github.com/dominikh/go-tools/lint/lintutil expects import "honnef.co/go/tools/lint/lintutil"
package github.com/dominikh/go-tools/lint/testutil: code in directory $GOPATH/src/github.com/dominikh/go-tools/lint/testutil expects import "honnef.co/go/tools/lint/testutil"
package github.com/dominikh/go-tools/simple: code in directory $GOPATH/src/github.com/dominikh/go-tools/simple expects import "honnef.co/go/tools/simple"
package github.com/dominikh/go-tools/ssa: code in directory $GOPATH/src/github.com/dominikh/go-tools/ssa expects import "honnef.co/go/tools/ssa"
package github.com/dominikh/go-tools/ssa/ssautil: code in directory $GOPATH/src/github.com/dominikh/go-tools/ssa/ssautil expects import "honnef.co/go/tools/ssa/ssautil"
package github.com/dominikh/go-tools/staticcheck: code in directory $GOPATH/src/github.com/dominikh/go-tools/staticcheck expects import "honnef.co/go/tools/staticcheck"
package github.com/dominikh/go-tools/stylecheck: code in directory $GOPATH/src/github.com/dominikh/go-tools/stylecheck expects import "honnef.co/go/tools/stylecheck"
package github.com/dominikh/go-tools/unused: code in directory $GOPATH/src/github.com/dominikh/go-tools/unused expects import "honnef.co/go/tools/unused"

So I think update it will be better.

@bhcleek
Copy link
Collaborator

bhcleek commented Aug 23, 2018

LGTM. Thanks for contributing.

@bhcleek bhcleek merged commit 07d5a9f into fatih:master Aug 23, 2018
bhcleek added a commit that referenced this pull request Aug 23, 2018
@jtr860830 jtr860830 deleted the patch-1 branch August 24, 2018 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants