fix guru output handling in Neovim #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Join shell arguments correctly when Neovim calls guru.
Output from a Neovim job may come in batches and splits on newlines. When the output ends with a newline, the last element in the data passed to the stdout and stderr callbacks will be the empty string. When it's not the empty string, then last element is an incomplete line, and the next call will contain the rest of the line in the first element of its data. Fixes fatih#1836
|
Isn't this a problem in all locations where we read from stdout/stderr in the async API? |
arp242
approved these changes
May 30, 2018
|
Your instincts are right; this is likely a problem in other places, too. It's not a problem everywhere, though, because some places use JSON instead of being line-oriented output. I'm planning to go through and unify the vim8 and Neovim async job handling so we can have a consistent approach. When I do that, I'll be sure to fix any code locations that also have this problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output from a Neovim job may come in batches and splits on newlines.
When the output ends with a newline, the last element in the data passed
to the stdout and stderr callbacks will be the empty string. When it's
not the empty string, then last element is an incomplete line, and the
next call will contain the rest of the line in the first element of its
data.
Join shell arguments correctly when Neovim calls guru.
Fixes #1836