Fix metalinter problems #1640
Fix metalinter problems #1640
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1640 +/- ##
==========================================
+ Coverage 19.3% 22.02% +2.71%
==========================================
Files 53 53
Lines 4159 4178 +19
==========================================
+ Hits 803 920 +117
+ Misses 3356 3258 -98
Continue to review full report at Codecov.
|
|
I think this is more or less the same as #1621 ? |
|
It's similar, for sure. But it also adds tests and fixes another issue that was wrong with I hadn't noticed #1621; sorry for the duplication of effort. |
bhcleek
force-pushed
the
fix-metalinter
branch
2 times, most recently
from
8cf156f to
6d18a1a
Compare
|
@Carpetsmoker I ran these tests against #1621, and found that #1621 still doesn't handle the relative pathing correctly. I'd prefer not to push over someone else's branch on their repo, so I rebased #1621 onto master, then rebased this branch on top of that, splitting my original two commits up into three, so that the last two commits each address one fix instead of combining them. |
|
@bhcleek after I merged your latest change this needs to be rebased again. |
When go#lint#Gometa is triggered by autosave, we attempt to only show lint warnings and errors that are applicable for the active buffer. This is done by passing the path to the file represented by the active buffer to gometalinter's `--include` option. The existing behaviour expands the absolute path, whereas gometalinter outputs paths that are relative to the current working directory. This change modifies the variable used for matching so that we also use the current working directory for matching against lint errors/warnings. Signed-off-by: Tom Barlow <[email protected]>
bhcleek
force-pushed
the
fix-metalinter
branch
from
6d18a1a to
7702f5c
Compare
|
@fatih I rebased it. |
|
Thanks @tombee @bhcleek @Carpetsmoker |
Make sure linter errors for the file being saved are shown in vim74 and
nvim.
Make sure only linter errors for the file being saved are shown in vim8.
Previously, all linter errors for all files in the current file's
directory were being shown.
Make sure gometalinter is run on the given directories when arguments
are given to
:GoMetaLinter.Fixes #1623