Show message when using :GoDef and opening a new buffer #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of: vim-go: SUCCESS We now show: vim-go: /usr/lib/go/src/strings/strings.go:340:6: defined here as func strings.Join Showing the output of the command is optional; if we remove it we get the old behaviour with the output of an `:edit` command: "/usr/lib/go/src/strings/strings.go" [readonly] 777L, 20971C Showing the command output seemed more useful to me personally though, I moved the `custom_cb()` invocation after the message; this has no real effect as far as I can see (it's used in only two places) and it allows us output messages after the SUCCESS. Fixes #1207
|
Seams a fair improvment. Merging it but gonna change the print to: as the file name might be very long . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of:
We now show:
Showing the output of the command is optional; if we remove it we get the old
behaviour with the output of an
:editcommand:Showing the command output seemed more useful to me personally though,
I moved the
custom_cb()invocation after the message; this has no real effectas far as I can see (it's used in only two places) and it allows us output
messages after the SUCCESS.
Fixes #1207