Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GoDef help: remove explicit arguments #1242

Merged
merged 1 commit into from
Mar 28, 2017

Conversation

danielheller
Copy link
Contributor

The GoDef command does not support specifiying identifiers on the
command line due to limitations in the Guru and Godef tools, which
operate on file positions. This change updates the help for GoDef to
remove an incorrect mention of explicit arguments.

The GoDef command does not support specifiying identifiers on the
command line due to limitations in the Guru and Godef tools, which
operate on file positions. This change updates the help for GoDef to
remove an incorrect mention of explicit arguments.
@fatih
Copy link
Owner

fatih commented Mar 28, 2017

Hi @danielheller

This looks good. godef itself actually also works on direct types instead of offset, however we don't support it for vim-go. Thanks for the PR.

@fatih fatih merged commit a83c4c0 into fatih:master Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants