Skip to content

support staticcheck #2538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bhcleek opened this issue Oct 7, 2019 · 2 comments · Fixed by #2612
Closed

support staticcheck #2538

bhcleek opened this issue Oct 7, 2019 · 2 comments · Fixed by #2612
Labels
improvement
Milestone
vim-go 1.22

Comments

@bhcleek
Copy link
Collaborator

bhcleek commented Oct 7, 2019 •
edited
Loading

Support staticcheck as a metalinter.

acceptance criteria

  • staticcheck is supported as a metalinter
  • staticcheck is supported as a metalinter for autosaving

open questions

  • should the g:go_metalinter_enabled, g:go_metalinter_disabled, and g:go_metalinter_autosave_enabled options apply to staticcheck? If so, should g:go_metalinter_autosave_disabled be allowed, too? Given staticcheck's config support, perhaps these don't make sense to use at all.
@bhcleek bhcleek added this to the vim-go 1.22 milestone Oct 7, 2019
@bhcleek
Copy link
Collaborator Author

bhcleek commented Nov 10, 2019

gopls is adding support for staticcheck, so instead of adding support as a metalinter, this will probably be done by adding support for surfacing the gopls diagnostics in a quickfix and/or location list.

bhcleek added a commit to bhcleek/vim-go that referenced this issue Dec 5, 2019
@bhcleek
lint: make gopls diagnostics visible
703ad1f 
Add a new comamnd, `:GoDiagnostics`, to display the LSP diagnostics for
packages.

Teach :GoMetaLinter to display LSP diagnostics when
g:go_metalinter_command == 'gopls'.

Closes fatih#2538
bhcleek added a commit to bhcleek/vim-go that referenced this issue Dec 5, 2019
@bhcleek
lint: make gopls diagnostics visible
828b59d 
Add a new comamnd, `:GoDiagnostics`, to display the LSP diagnostics for
packages.

Teach :GoMetaLinter to display LSP diagnostics when
g:go_metalinter_command == 'gopls'.

Closes fatih#2538
@bhcleek bhcleek mentioned this issue Dec 5, 2019
Merged
bhcleek added a commit to bhcleek/vim-go that referenced this issue Dec 5, 2019
@bhcleek
lint: make gopls diagnostics visible
20e5861 
Add a new comamnd, `:GoDiagnostics`, to display the LSP diagnostics for
packages.

Teach :GoMetaLinter to display LSP diagnostics when
g:go_metalinter_command == 'gopls'.

Closes fatih#2538
bhcleek added a commit to bhcleek/vim-go that referenced this issue Dec 13, 2019
@bhcleek
lint: make gopls diagnostics visible
1f3c1bb 
Add a new comamnd, `:GoDiagnostics`, to display the LSP diagnostics for
packages.

Teach :GoMetaLinter to display LSP diagnostics when
g:go_metalinter_command == 'gopls'.

Closes fatih#2538
bhcleek added a commit to bhcleek/vim-go that referenced this issue Dec 13, 2019
@bhcleek
lint: make gopls diagnostics visible
e37e1f1 
Add a new comamnd, `:GoDiagnostics`, to display the LSP diagnostics for
packages.

Teach :GoMetaLinter to display LSP diagnostics when
g:go_metalinter_command == 'gopls'.

Closes fatih#2538
bhcleek added a commit to bhcleek/vim-go that referenced this issue Dec 13, 2019
@bhcleek
lint: make gopls diagnostics visible
9a64152 
Add a new comamnd, `:GoDiagnostics`, to display the LSP diagnostics for
packages.

Teach :GoMetaLinter to display LSP diagnostics when
g:go_metalinter_command == 'gopls'.

Closes fatih#2538
bhcleek added a commit to bhcleek/vim-go that referenced this issue Dec 13, 2019
@bhcleek
lint: make gopls diagnostics visible
721a7b8 
Add a new command, `:GoDiagnostics`, to display the LSP diagnostics for
packages.

Teach :GoMetaLinter to display LSP diagnostics when
g:go_metalinter_command == 'gopls'.

Closes fatih#2538
bhcleek added a commit to bhcleek/vim-go that referenced this issue Dec 13, 2019
@bhcleek
lint: make gopls diagnostics visible
403b6e1 
Add a new command, `:GoDiagnostics`, to display the LSP diagnostics for
packages.

Teach :GoMetaLinter to display LSP diagnostics when
g:go_metalinter_command == 'gopls'.

Closes fatih#2538
bhcleek added a commit to bhcleek/vim-go that referenced this issue Dec 16, 2019
@bhcleek
lint: make gopls diagnostics visible
b095c56 
Add a new command, `:GoDiagnostics`, to display the LSP diagnostics for
packages.

Teach :GoMetaLinter to display LSP diagnostics when
g:go_metalinter_command == 'gopls'.

Closes fatih#2538
@ahuret
Copy link

ahuret commented Dec 17, 2019

Should it be possible to surface error not with :GoDiagnostic, but when cursor is over the error ? ( and see error surfacing below, the same way vim give information about saving file etc.) thx !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
vim-go 1.22
Development

Successfully merging a pull request may close this issue.

surface gopls diagnostics bhcleek/vim-go
2 participants
@bhcleek @ahuret