Skip to content

[CDTOOL-1055] Add support for ngwaf workspaces #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 16, 2025
Merged

[CDTOOL-1055] Add support for ngwaf workspaces #679

merged 5 commits into from
May 16, 2025

Conversation

philippschulte
Copy link
Member

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

@philippschulte philippschulte requested a review from a team as a code owner May 14, 2025 19:01
@philippschulte philippschulte added the enhancement New feature or request label May 14, 2025
@philippschulte philippschulte requested a review from kpfleming May 14, 2025 19:01
philippschulte
philippschulte commented May 14, 2025
View reviewed changes
philippschulte
philippschulte commented May 14, 2025
View reviewed changes
philippschulte
philippschulte commented May 14, 2025
View reviewed changes
philippschulte
philippschulte commented May 14, 2025
View reviewed changes
kpfleming
kpfleming approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@kpfleming kpfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very small changes suggested, but otherwise this looks great.

anthony-gomez-fastly
anthony-gomez-fastly reviewed May 15, 2025
View reviewed changes
anthony-gomez-fastly
anthony-gomez-fastly reviewed May 15, 2025
View reviewed changes
anthony-gomez-fastly
anthony-gomez-fastly approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor

@anthony-gomez-fastly anthony-gomez-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@philippschulte philippschulte merged commit 588f96b into fastly:main May 16, 2025
4 checks passed
@philippschulte philippschulte deleted the pschulte/CDTOOL-1055_add-support-for-workspace-api branch May 16, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpfleming kpfleming kpfleming approved these changes

@anthony-gomez-fastly anthony-gomez-fastly anthony-gomez-fastly approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philippschulte @kpfleming @anthony-gomez-fastly