Surrogate keys in core cache API #484
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cceckman-at-fastly
changed the base branch from
main
to
cceckman/stale-while-revalidate
cceckman-at-fastly
force-pushed
the
cceckman/surrogate-keys
branch
from
f25db00 to
affbd1a
Compare
This covers all the currently-available options of `insert` calls. Range requests still require the experimental flag.
Return an error if the caller provides (according to the mask) a write option that is not handled by load_write_options.
cceckman-at-fastly
force-pushed
the
cceckman/surrogate-keys
branch
from
affbd1a to
d603fce
Compare
And properly count items soft-purged, as turned up by the unit test.
cceckman-at-fastly
force-pushed
the
cceckman/surrogate-keys
branch
from
d6b3e67 to
8302b92
Compare
aturon
reviewed
Jun 3, 2025
Fix a missing branch that would drop the `CacheValue` from under an existing `Obligation`. The "revalidate" means that we can have `value.present.is_some()` and `value.obligated` together. Clarify the comment about when notifications are needed, and always return `false` (because they are never needed from this block).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for surrogate keys and purging thereby.
Check that we consume all the options for
insert-like operationsand
purge, so if an SDK starts using an option Viceroy doesn't understand, it fails visibly.