fix(userspace/falco): only enable prometheus metrics once all inspectors have been opened #3588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ors have been opened. Signed-off-by: Federico Di Pierro <[email protected]>
|
/milestone 0.42.0 |
Signed-off-by: Federico Di Pierro <[email protected]>
FedeDP
force-pushed
the
fix/only_enable_prometheus_after_inspectors_opened
branch
from
37180b4 to
a68b5bc
Compare
leogr
approved these changes
May 30, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, incertum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/milestone 0.41.1 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
There is a certain slice of team where prometheus metrics are exposed but the inspectors for all the enabled sources are not opened yet.
In this scenario, if eg: grafana scrapes our metrics, it would trigger a Falco crash because metrics need the inspectors to be fully inited and opened.
Which issue(s) this PR fixes:
Fixes #3571
Special notes for your reviewer:
Does this PR introduce a user-facing change?: