Skip to content

chore: ignore some lint warnings in tests #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 17, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented May 15, 2022

Fixing this warnings would require more coding/casting and reduce the readability without any real benefit.

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent labels May 15, 2022
@ST-DDT ST-DDT requested review from a team May 15, 2022 13:33
@ST-DDT ST-DDT self-assigned this May 15, 2022
@codecov
Copy link

codecov bot commented May 15, 2022

Codecov Report

Merging #961 (e4d39dc) into main (ad9bf23) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #961   +/-   ##
=======================================
  Coverage   99.66%   99.66%           
=======================================
  Files        1970     1970           
  Lines      209928   209928           
  Branches      876      876           
=======================================
  Hits       209215   209215           
  Misses        694      694           
  Partials       19       19           

@ST-DDT ST-DDT enabled auto-merge (squash) May 17, 2022 06:37
@ST-DDT ST-DDT merged commit f9a1415 into main May 17, 2022
@ST-DDT ST-DDT deleted the chore/ignore-some-lint-warnings-in-tests branch May 17, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants