Skip to content

docs(docs/guide): Add typescript support in the guide #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 15, 2022
Merged

docs(docs/guide): Add typescript support in the guide #947

merged 3 commits into from
May 15, 2022

Conversation

ch1lam
Copy link
Contributor

@ch1lam ch1lam commented May 12, 2022

No description provided.

@ch1lam ch1lam requested a review from a team May 12, 2022 09:13
@ch1lam ch1lam requested a review from a team as a code owner May 12, 2022 09:13
@ch1lam ch1lam changed the title Add typescript support in the guide docs(docs/guide): Add typescript support in the guide May 12, 2022
@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels May 12, 2022
@ST-DDT ST-DDT added this to the v7 - Current Major milestone May 12, 2022
@codecov
Copy link

codecov bot commented May 12, 2022 •
edited
Loading

Codecov Report

Merging #947 (1149996) into main (fa0a3d1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #947   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files        1957     1957           
  Lines      209831   209831           
  Branches      877      877           
=======================================
  Hits       209109   209109           
  Misses        702      702           
  Partials       20       20

Shinigami92
Shinigami92 previously approved these changes May 12, 2022
View reviewed changes
@Shinigami92
Copy link
Member

A windows user was spotted 👁️

@ch1lam
Copy link
Contributor Author

ch1lam commented May 12, 2022

A windows user was spotted 👁️

Yes, I'm more used to using windows. This is the problem I found while reading the guide, which is not the same as the README.md. And this is my first PR on github, it might not be standardized enough.😳

@Shinigami92
Copy link
Member

Yes, I'm more used to using windows. This is the problem I found while reading the guide, which is not the same as the README.md. And this is my first PR on github, it might not be standardized enough.😳

You may want to configure autocrlf https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings

@ch1lam
Copy link
Contributor Author

ch1lam commented May 12, 2022

You may want to configure autocrlf https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings

Oh thanks, this is very useful for me.🙂

@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label May 12, 2022
@ST-DDT ST-DDT enabled auto-merge (squash) May 15, 2022 11:26
@ST-DDT ST-DDT merged commit f12fbf6 into faker-js:main May 15, 2022
@ch1lam ch1lam deleted the docs-fix-usage branch May 15, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ejcheng ejcheng ejcheng approved these changes

Assignees
No one assigned
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.
4 participants
@ch1lam @Shinigami92 @ST-DDT @ejcheng