Skip to content

chore: fix lint warning in address module #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented May 8, 2022

grafik

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent labels May 8, 2022
@ST-DDT ST-DDT requested review from a team May 8, 2022 21:23
@ST-DDT ST-DDT self-assigned this May 8, 2022
@codecov
Copy link

codecov bot commented May 8, 2022

Codecov Report

Merging #938 (5b2d39b) into main (69eedd7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #938   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files        1957     1957           
  Lines      209831   209831           
  Branches      877      878    +1     
=======================================
+ Hits       209109   209112    +3     
+ Misses        702      699    -3     
  Partials       20       20           
Impacted Files Coverage Δ
src/modules/address/index.ts 99.79% <100.00%> (ø)
src/modules/finance/index.ts 100.00% <0.00%> (+0.68%) ⬆️

@ejcheng ejcheng requested a review from a team May 8, 2022 21:36
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label May 12, 2022
@ST-DDT ST-DDT enabled auto-merge (squash) May 12, 2022 22:26
@ST-DDT ST-DDT merged commit 6219c94 into main May 12, 2022
@ST-DDT ST-DDT deleted the chore/fix-address-eslint-warning branch May 12, 2022 23:03
@xDivisionByZerox xDivisionByZerox added the m: location Something is referring to the location module label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior m: location Something is referring to the location module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants