chore: fix any warnings in image module #886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #886 +/- ##
==========================================
- Coverage 99.42% 99.41% -0.01%
==========================================
Files 1958 1959 +1
Lines 210811 210830 +19
Branches 900 901 +1
==========================================
+ Hits 209598 209600 +2
- Misses 1156 1172 +16
- Partials 57 58 +1
|
|
I'm not sure how I can add coverage for types aside from using them... |
ejcheng
previously approved these changes
Apr 28, 2022
ST-DDT
force-pushed
the
chore/fix-image-any-warnings
branch
from
cc888a6 to
422d457
Compare
Shinigami92
approved these changes
Apr 29, 2022
pkuczynski
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
56 -> 54 warnings
I'm not sure whether I should publicly expose the custom types.
I do intent to use them in some tests in the future though.