Skip to content

ci: use gh-action for validating PR title #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2022
Merged

ci: use gh-action for validating PR title #845

merged 2 commits into from
Apr 19, 2022

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Apr 19, 2022 •
edited
Loading

closes #843

@Shinigami92 Shinigami92 added c: bug Something isn't working c: chore PR that doesn't affect the runtime behavior p: 2-high Fix main branch s: accepted Accepted feature / Confirmed bug labels Apr 19, 2022
@Shinigami92 Shinigami92 added this to the v6 - Non-Breaking Changes milestone Apr 19, 2022
@Shinigami92 Shinigami92 requested a review from a team as a code owner April 19, 2022 14:00
@Shinigami92 Shinigami92 self-assigned this Apr 19, 2022
@Shinigami92 Shinigami92 linked an issue Apr 19, 2022 that may be closed by this pull request
investigate stalling semantic pull request #843
Closed
@Shinigami92 Shinigami92 requested a review from a team April 19, 2022 14:01
@codecov
Copy link

codecov bot commented Apr 19, 2022 •
edited
Loading

Codecov Report

Merging #845 (92045a6) into main (360bec7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #845   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1921     1921           
  Lines      179170   179170           
  Branches      895      895           
=======================================
  Hits       177993   177993           
  Misses       1121     1121           
  Partials       56       56

pkuczynski
pkuczynski previously requested changes Apr 19, 2022
View reviewed changes
@pkuczynski
Copy link
Member

In the other open source projects I was happy with using https://github.com/mergeability/mergeable - very configurable and allows many different checks including file dependencies...

@Shinigami92 Shinigami92 requested review from pkuczynski and a team April 19, 2022 14:41
@ST-DDT
Copy link
Member

ST-DDT commented Apr 19, 2022

I'm not familiar with either of them, so I'm fine either way.

@ST-DDT ST-DDT requested a review from a team April 19, 2022 14:54
@Shinigami92 Shinigami92 merged commit d94159f into main Apr 19, 2022
@Shinigami92 Shinigami92 deleted the 843-investigate-stalling-semantic-pull-request branch April 19, 2022 17:41
@bluwy bluwy mentioned this pull request Apr 20, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@prisis prisis prisis approved these changes

@ejcheng ejcheng ejcheng approved these changes

@pkuczynski pkuczynski Awaiting requested review from pkuczynski

Assignees

@Shinigami92 Shinigami92

Labels
c: bug Something isn't working c: chore PR that doesn't affect the runtime behavior p: 2-high Fix main branch s: accepted Accepted feature / Confirmed bug
Projects
None yet
Milestone
v6.2 - New small features
Development

Successfully merging this pull request may close these issues.

investigate stalling semantic pull request
5 participants
@Shinigami92 @pkuczynski @ST-DDT @prisis @ejcheng