-
-
Notifications
You must be signed in to change notification settings - Fork 975
docs: fix mersenne rand min max confusion #839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #839 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 2110 2110
Lines 225732 225732
Branches 979 979
=======================================
Hits 224992 224992
Misses 720 720
Partials 20 20
|
ejcheng
requested changes
Apr 15, 2022
Shinigami92
reviewed
Apr 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume it was implemented with max as first param, so that a user can use it with faker.mersenne.rand(6)
so without a min argument and it just has a default min = 0
Shinigami92
approved these changes
May 23, 2022
Shinigami92
requested changes
May 23, 2022
although mersenne automatically swap the value if min is bigger than max, but it's a good practice to clear out the confusion
5447b65
to
d6d3465
Compare
Shinigami92
approved these changes
May 23, 2022
ST-DDT
approved these changes
May 23, 2022
ejcheng
approved these changes
May 23, 2022
xDivisionByZerox
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: docs
Improvements or additions to documentation
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
although mersenne automatically swap the value if min is bigger than max, but it's a good practice to clear out the confusion.
Fix #775