Skip to content

docs: fix lost description texts #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 20, 2022
Merged

docs: fix lost description texts #836

merged 7 commits into from
Apr 20, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Apr 12, 2022

Fixes #794

Here a few examples of the changes:

Old1 (Click to exand)

grafik

New1 (Click to exand)

grafik

Old2 (Click to exand)

grafik

New2 (Click to exand)

grafik

Old3 (Click to exand)

grafik

New3 (Click to exand)

grafik

I'm not sure about the CSS changes. IIRC we discussed at some point to not use it, but I don't remember why anymore.
If we don't display it as list items, then we have to remove the padding from the list though.

@ST-DDT ST-DDT added c: bug Something isn't working c: docs Improvements or additions to documentation labels Apr 12, 2022
@ST-DDT ST-DDT added this to the v6.2 - New small features milestone Apr 12, 2022
@ST-DDT ST-DDT requested review from a team April 12, 2022 20:09
@ST-DDT ST-DDT requested a review from a team as a code owner April 12, 2022 20:09
@ST-DDT ST-DDT self-assigned this Apr 12, 2022
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #836 (ff374e3) into main (00b9d4b) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head ff374e3 differs from pull request most recent head 70cf47f. Consider uploading reports for the commit 70cf47f to get more accurate results

@@            Coverage Diff             @@
##             main     #836      +/-   ##
==========================================
- Coverage   99.35%   99.34%   -0.02%     
==========================================
  Files        1922     1921       -1     
  Lines      183050   179524    -3526     
  Branches      900      898       -2     
==========================================
- Hits       181876   178347    -3529     
- Misses       1118     1121       +3     
  Partials       56       56              
Impacted Files Coverage Δ
src/internet.ts 100.00% <100.00%> (ø)
src/time.ts 100.00% <100.00%> (ø)
src/utils/user-agent.ts 98.11% <0.00%> (-0.73%) ⬇️
src/commerce.ts 100.00% <0.00%> (ø)
src/definitions/internet.ts 100.00% <0.00%> (ø)
src/locales/en/internet/index.ts 100.00% <0.00%> (ø)
src/locales/en/internet/emoji.ts
src/finance.ts 99.31% <0.00%> (+0.01%) ⬆️
src/system.ts 96.41% <0.00%> (+0.01%) ⬆️

ejcheng
ejcheng previously approved these changes Apr 12, 2022
@ejcheng ejcheng added the p: 1-normal Nothing urgent label Apr 12, 2022
pkuczynski
pkuczynski previously approved these changes Apr 12, 2022
@ST-DDT ST-DDT enabled auto-merge (squash) April 13, 2022 08:07
@ST-DDT ST-DDT disabled auto-merge April 13, 2022 08:20
@ST-DDT ST-DDT enabled auto-merge (squash) April 13, 2022 08:20
@ST-DDT ST-DDT dismissed stale reviews from pkuczynski and ejcheng via 8a55c1b April 19, 2022 18:34
@ST-DDT ST-DDT requested review from a team and Shinigami92 April 19, 2022 18:35
@ST-DDT ST-DDT merged commit b99bbb5 into main Apr 20, 2022
@Shinigami92 Shinigami92 deleted the docs/lost-description-text branch April 20, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Api docs parameter default extraction removes parts of the description
4 participants