-
-
Notifications
You must be signed in to change notification settings - Fork 975
docs: fix lost description texts #836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #836 +/- ##
==========================================
- Coverage 99.35% 99.34% -0.02%
==========================================
Files 1922 1921 -1
Lines 183050 179524 -3526
Branches 900 898 -2
==========================================
- Hits 181876 178347 -3529
- Misses 1118 1121 +3
Partials 56 56
|
ejcheng
previously approved these changes
Apr 12, 2022
pkuczynski
previously approved these changes
Apr 12, 2022
Shinigami92
reviewed
Apr 16, 2022
Shinigami92
requested changes
Apr 19, 2022
Shinigami92
approved these changes
Apr 19, 2022
ejcheng
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: bug
Something isn't working
c: docs
Improvements or additions to documentation
p: 1-normal
Nothing urgent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #794
Here a few examples of the changes:
Old1 (Click to exand)
New1 (Click to exand)
Old2 (Click to exand)
New2 (Click to exand)
Old3 (Click to exand)
New3 (Click to exand)
I'm not sure about the CSS changes. IIRC we discussed at some point to not use it, but I don't remember why anymore.
If we don't display it as list items, then we have to remove the padding from the list though.