Skip to content

chore: use consistent method calls #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Apr 8, 2022
@Shinigami92 Shinigami92 added this to the v6.2 - New small features milestone Apr 8, 2022
@Shinigami92 Shinigami92 self-assigned this Apr 8, 2022
@Shinigami92 Shinigami92 requested a review from a team as a code owner April 8, 2022 16:02
@Shinigami92 Shinigami92 requested review from pkuczynski and a team April 8, 2022 16:02
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #817 (910a189) into main (3b5a21f) will decrease coverage by 0.00%.
The diff coverage is 98.50%.

@@            Coverage Diff             @@
##             main     #817      +/-   ##
==========================================
- Coverage   99.35%   99.35%   -0.01%     
==========================================
  Files        1921     1921              
  Lines      179107   179086      -21     
  Branches      911      909       -2     
==========================================
- Hits       177955   177934      -21     
  Misses       1096     1096              
  Partials       56       56              
Impacted Files Coverage Δ
src/name.ts 98.57% <75.00%> (ø)
src/address.ts 99.81% <100.00%> (ø)
src/commerce.ts 100.00% <100.00%> (ø)
src/company.ts 100.00% <100.00%> (ø)
src/datatype.ts 100.00% <100.00%> (ø)
src/finance.ts 99.31% <100.00%> (ø)
src/helpers.ts 99.27% <100.00%> (ø)
src/image.ts 98.83% <100.00%> (ø)
src/internet.ts 100.00% <100.00%> (ø)
src/lorem.ts 100.00% <100.00%> (ø)
... and 2 more

ST-DDT
ST-DDT previously approved these changes Apr 8, 2022
@ST-DDT ST-DDT requested a review from a team April 8, 2022 16:25
@ST-DDT ST-DDT requested a review from a team April 8, 2022 16:42
@Shinigami92 Shinigami92 merged commit 753ab66 into main Apr 8, 2022
@Shinigami92 Shinigami92 deleted the chore-consitent-method-calls branch April 8, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants