Skip to content

docs: update faker.fake documentation #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 29, 2022
Merged

docs: update faker.fake documentation #709

merged 7 commits into from
Mar 29, 2022

Conversation

pkuczynski
Copy link
Member

@pkuczynski pkuczynski commented Mar 28, 2022 •
edited
Loading

Follow up for #701 (review)

@pkuczynski pkuczynski requested a review from a team as a code owner March 28, 2022 17:46
@pkuczynski pkuczynski self-assigned this Mar 28, 2022
@pkuczynski pkuczynski added the c: docs Improvements or additions to documentation label Mar 28, 2022
@pkuczynski pkuczynski added this to the v6.1 - First bugfixes milestone Mar 28, 2022
@codecov
Copy link

codecov bot commented Mar 28, 2022 •
edited
Loading

Codecov Report

Merging #709 (0cb4581) into main (928f5d3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0cb4581 differs from pull request most recent head a797548. Consider uploading reports for the commit a797548 to get more accurate results

@@           Coverage Diff           @@
##             main     #709   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1924     1924           
  Lines      176983   176993   +10     
  Branches      904      904           
=======================================
+ Hits       175822   175832   +10     
  Misses       1105     1105           
  Partials       56       56
Impacted Files Coverage Δ
src/fake.ts 100.00% <100.00%> (ø)

ST-DDT
ST-DDT requested changes Mar 28, 2022
View reviewed changes
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Mar 28, 2022
@pkuczynski pkuczynski requested a review from ST-DDT March 28, 2022 18:24
ST-DDT
ST-DDT requested changes Mar 28, 2022
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about my grammar change suggestions.

@pkuczynski pkuczynski requested a review from ST-DDT March 28, 2022 19:05
@pkuczynski pkuczynski requested a review from Shinigami92 March 28, 2022 19:49
ST-DDT
ST-DDT previously approved these changes Mar 28, 2022
View reviewed changes
@ST-DDT ST-DDT requested review from a team March 28, 2022 20:18
ejcheng
ejcheng reviewed Mar 28, 2022
View reviewed changes
xDivisionByZerox
xDivisionByZerox reviewed Mar 28, 2022
View reviewed changes
ejcheng
ejcheng previously approved these changes Mar 28, 2022
View reviewed changes
xDivisionByZerox
xDivisionByZerox reviewed Mar 28, 2022
View reviewed changes
@ejcheng ejcheng self-requested a review March 28, 2022 21:00
@Shinigami92 Shinigami92 enabled auto-merge (squash) March 29, 2022 07:19
@Shinigami92 Shinigami92 merged commit 1bb0f25 into faker-js:main Mar 29, 2022
@pkuczynski pkuczynski deleted the fake-docs branch March 29, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ejcheng ejcheng ejcheng approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@pkuczynski pkuczynski

Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Milestone
v6.1 - First bugfixes
Development

Successfully merging this pull request may close these issues.
5 participants
@pkuczynski @ST-DDT @Shinigami92 @ejcheng @xDivisionByZerox