Skip to content

refactor: replace intern use of helper.randomize #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2022
Merged

refactor: replace intern use of helper.randomize #687

merged 2 commits into from
Mar 26, 2022

Conversation

xDivisionByZerox
Copy link
Member

Since we deprecated helpers.randomize in #506 I think we shouldn't use it internally anymore. This PR replaces all helpers.randomize calls with random.arrayElement.

@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner March 26, 2022 16:35
@codecov
Copy link

codecov bot commented Mar 26, 2022

Codecov Report

Merging #687 (535a8f0) into main (3aea453) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 535a8f0 differs from pull request most recent head d71d561. Consider uploading reports for the commit d71d561 to get more accurate results

@@           Coverage Diff           @@
##             main     #687   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1923     1923           
  Lines      176883   176886    +3     
  Branches      897      897           
=======================================
+ Hits       175728   175731    +3     
  Misses       1099     1099           
  Partials       56       56           
Impacted Files Coverage Δ
src/finance.ts 100.00% <100.00%> (ø)
src/helpers.ts 99.12% <100.00%> (+<0.01%) ⬆️
src/address.ts 99.10% <0.00%> (-0.01%) ⬇️

@Shinigami92 Shinigami92 added the c: chore PR that doesn't affect the runtime behavior label Mar 26, 2022
@Shinigami92 Shinigami92 added this to the v6.1 - First bugfixes milestone Mar 26, 2022
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Mar 26, 2022
@Shinigami92 Shinigami92 requested review from a team March 26, 2022 16:53
@Shinigami92 Shinigami92 enabled auto-merge (squash) March 26, 2022 17:58
@Shinigami92 Shinigami92 merged commit 81740ff into faker-js:main Mar 26, 2022
@xDivisionByZerox xDivisionByZerox deleted the replace-intern-randomize-use branch March 26, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants