Skip to content

ci: reduce diff coverage target #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

griest024
Copy link
Contributor

this should accommodate refactor PRs that increase uncovered lines

this should accommodate refactor PRs that increase uncovered lines
@griest024 griest024 requested a review from a team as a code owner March 23, 2022 20:16
@Shinigami92 Shinigami92 requested a review from a team March 23, 2022 20:17
@Shinigami92 Shinigami92 added the p: 2-high Fix main branch label Mar 23, 2022
@Shinigami92 Shinigami92 added c: chore PR that doesn't affect the runtime behavior s: accepted Accepted feature / Confirmed bug labels Mar 23, 2022
@ST-DDT ST-DDT requested a review from a team March 23, 2022 20:28
@Shinigami92
Copy link
Member

Shinigami92 commented Mar 23, 2022

Somehow it cannot find the codecov token? Is this because it's coming from your fork? I'm confused 🤔

image

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #663 (082cf11) into main (1b08de8) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #663   +/-   ##
=======================================
  Coverage   99.33%   99.33%           
=======================================
  Files        1923     1923           
  Lines      176857   176857           
  Branches      906      908    +2     
=======================================
+ Hits       175685   175687    +2     
+ Misses       1116     1114    -2     
  Partials       56       56           
Impacted Files Coverage Δ
src/vendor/unique.ts 95.16% <0.00%> (+1.61%) ⬆️

@Shinigami92 Shinigami92 merged commit 825a8c8 into faker-js:main Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior p: 2-high Fix main branch s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants