-
-
Notifications
You must be signed in to change notification settings - Fork 975
docs: read (complex) defaults from implementation signature #656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eb3a280
to
988f61a
Compare
Codecov Report
@@ Coverage Diff @@
## main #656 +/- ##
=======================================
Coverage 99.33% 99.33%
=======================================
Files 1923 1923
Lines 176857 176857
Branches 908 908
=======================================
Hits 175687 175687
Misses 1114 1114
Partials 56 56 |
Shinigami92
reviewed
Mar 22, 2022
ST-DDT
commented
Mar 22, 2022
Shinigami92
previously approved these changes
Mar 22, 2022
53050a3
to
9426b38
Compare
Shinigami92
approved these changes
Mar 23, 2022
prisis
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: docs
Improvements or additions to documentation
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows displaying potentially complex (expressions, options, arrays) default values in the docs.
Here an example with a fictional expression default value.
Here is an example from the actual docs:
Old
New
Diff