-
-
Notifications
You must be signed in to change notification settings - Fork 975
test: fix all_functional tests #609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
429a734
to
ac8904d
Compare
ac8904d
to
b2b7d57
Compare
Codecov Report
@@ Coverage Diff @@
## main #609 +/- ##
==========================================
- Coverage 99.34% 99.34% -0.01%
==========================================
Files 1923 1923
Lines 176891 176887 -4
Branches 896 895 -1
==========================================
- Hits 175735 175727 -8
- Misses 1100 1104 +4
Partials 56 56
|
Shinigami92
reviewed
Mar 26, 2022
1a62741
to
23c17ee
Compare
Shinigami92
approved these changes
Mar 28, 2022
ejcheng
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
all_functional.spec.ts
doesn't work as expected. We need to fix this eventually.This conceals 20 errors:
We have to check how we fix these issues.
Some fixes require changes to the definitions, other require changes to the code itself.
The
fake()
test works as expected I just improved/narrowed the check.