Skip to content

chore: refactor datatype array function #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 1, 2022
Merged

chore: refactor datatype array function #566

merged 4 commits into from
Mar 1, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Feb 25, 2022

No description provided.

@ST-DDT ST-DDT added the c: feature Request for new feature label Feb 25, 2022
@ST-DDT ST-DDT self-assigned this Feb 25, 2022
@ST-DDT ST-DDT requested a review from a team as a code owner February 25, 2022 20:12
@codecov
Copy link

codecov bot commented Feb 25, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@ced5f3d). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head b2f14db differs from pull request most recent head ffb927f. Consider uploading reports for the commit ffb927f to get more accurate results

@@           Coverage Diff           @@
##             main     #566   +/-   ##
=======================================
  Coverage        ?   99.34%           
=======================================
  Files           ?     1920           
  Lines           ?   176366           
  Branches        ?      906           
=======================================
  Hits            ?   175211           
  Misses          ?     1099           
  Partials        ?       56
Impacted Files Coverage Δ
src/datatype.ts 99.66% <100.00%> (ø)

@ST-DDT
Copy link
Member Author

ST-DDT commented Feb 25, 2022

Fixes:

grafik

Found in https://github.com/faker-js/faker/pull/563/files#diff-5699f20396717381133051426f9769465b1d8d460c942def407bb4f03907d5c3R271

@Shinigami92 Shinigami92 changed the title types: fix missing variable type chore: refactor datatype array function Feb 25, 2022
@Shinigami92 Shinigami92 requested a review from a team February 25, 2022 21:23
@ejcheng ejcheng added the c: chore PR that doesn't affect the runtime behavior label Feb 26, 2022
@Shinigami92 Shinigami92 merged commit 748086b into main Mar 1, 2022
@Shinigami92 Shinigami92 deleted the types/random/array/variable-types branch March 1, 2022 18:20
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
@ST-DDT @Shinigami92 @demipel8
chore: refactor datatype array function (faker-js#566)
61c6b51 
Co-authored-by: Shinigami <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prisis prisis prisis approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: chore PR that doesn't affect the runtime behavior c: feature Request for new feature
Projects
None yet
Milestone
v6.0 - Ensure Project Foundation
Development

Successfully merging this pull request may close these issues.
4 participants
@ST-DDT @prisis @Shinigami92 @ejcheng