Skip to content

refactor: set seed directly #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 24, 2022
Merged

refactor: set seed directly #563

merged 4 commits into from
Mar 24, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Feb 25, 2022

Instead of abusing two constructors to call a method, we could just call the method directly.

@ST-DDT ST-DDT added the c: feature Request for new feature label Feb 25, 2022
@ST-DDT ST-DDT self-assigned this Feb 25, 2022
@ST-DDT ST-DDT requested a review from a team as a code owner February 25, 2022 18:03
@ST-DDT
Copy link
Member Author

ST-DDT commented Feb 25, 2022

Should this be in v6.0 or v6.1?

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #563 (40bfc38) into main (301a6d2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 40bfc38 differs from pull request most recent head 9dd60a4. Consider uploading reports for the commit 9dd60a4 to get more accurate results

@@           Coverage Diff           @@
##             main     #563   +/-   ##
=======================================
  Coverage   99.33%   99.34%           
=======================================
  Files        1923     1923           
  Lines      176860   176845   -15     
  Branches      917      912    -5     
=======================================
- Hits       175692   175679   -13     
+ Misses       1112     1110    -2     
  Partials       56       56           
Impacted Files Coverage Δ
src/datatype.ts 100.00% <100.00%> (+0.33%) ⬆️
src/faker.ts 100.00% <100.00%> (ø)
src/random.ts 99.41% <100.00%> (+0.18%) ⬆️
src/fake.ts 100.00% <0.00%> (ø)

@Shinigami92
Copy link
Member

Because this is a breaking change, we cannot put it into 6.0

@ST-DDT ST-DDT added this to the v6.1 - First bugfixes milestone Feb 25, 2022
@ejcheng ejcheng added the c: chore PR that doesn't affect the runtime behavior label Feb 26, 2022
@ST-DDT ST-DDT force-pushed the chore/set-seed-directly branch from c12ae3b to b042aa8 Compare March 7, 2022 20:40
Shinigami92
Shinigami92 previously approved these changes Mar 10, 2022
@Shinigami92
Copy link
Member

Maybe we need another label than p1-chore because that has the description that it does not change code behaviour. But this PR does change how the class constructors are called.

@ST-DDT ST-DDT requested a review from a team March 10, 2022 23:10
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs and removed c: feature Request for new feature c: chore PR that doesn't affect the runtime behavior labels Mar 15, 2022
@ST-DDT ST-DDT force-pushed the chore/set-seed-directly branch from b042aa8 to 2432394 Compare March 21, 2022 10:02
@ST-DDT ST-DDT force-pushed the chore/set-seed-directly branch from 2432394 to 8f3b652 Compare March 21, 2022 13:43
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Mar 21, 2022
@ST-DDT ST-DDT requested a review from Shinigami92 March 21, 2022 13:44
Shinigami92
Shinigami92 previously approved these changes Mar 21, 2022
@Shinigami92 Shinigami92 changed the title chore: set seed directly refactor: set seed directly Mar 21, 2022
@ST-DDT ST-DDT requested a review from a team March 21, 2022 13:57
@ST-DDT ST-DDT force-pushed the chore/set-seed-directly branch from 8f3b652 to aecdf0a Compare March 21, 2022 23:40
Shinigami92
Shinigami92 previously approved these changes Mar 22, 2022
@Shinigami92 Shinigami92 requested a review from a team March 22, 2022 14:57
@Shinigami92 Shinigami92 requested a review from a team March 24, 2022 07:18
@Shinigami92 Shinigami92 enabled auto-merge (squash) March 24, 2022 08:08
@Shinigami92 Shinigami92 merged commit fe62c19 into main Mar 24, 2022
@Shinigami92 Shinigami92 deleted the chore/set-seed-directly branch March 24, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants