-
-
Notifications
You must be signed in to change notification settings - Fork 976
refactor: set seed directly #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should this be in v6.0 or v6.1? |
Codecov Report
@@ Coverage Diff @@
## main #563 +/- ##
=======================================
Coverage 99.33% 99.34%
=======================================
Files 1923 1923
Lines 176860 176845 -15
Branches 917 912 -5
=======================================
- Hits 175692 175679 -13
+ Misses 1112 1110 -2
Partials 56 56
|
Because this is a breaking change, we cannot put it into 6.0 |
c12ae3b
to
b042aa8
Compare
Maybe we need another label than |
b042aa8
to
2432394
Compare
2432394
to
8f3b652
Compare
8f3b652
to
aecdf0a
Compare
c7d8d29
to
7eeca18
Compare
Instead of abusing two constructors to call a method, we could just call the method directly.