Skip to content

chore: deprecate helpers.*Card methods #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 21, 2022
Merged

chore: deprecate helpers.*Card methods #543

merged 4 commits into from
Mar 21, 2022

Conversation

sprohaszka
Copy link
Contributor

Related to issue #528

Deprecate the following methods:

  • helpers.userCard
  • helpers.contextualCard
  • helpers.createCard

Replace example in README.

@sprohaszka sprohaszka requested a review from a team as a code owner February 22, 2022 19:01
@sprohaszka sprohaszka changed the title Deprecate helpers.*Card methods chore: Deprecate helpers.*Card methods Feb 22, 2022
@sprohaszka sprohaszka changed the title chore: Deprecate helpers.*Card methods chore: ceprecate helpers.*Card methods Feb 22, 2022
@ST-DDT ST-DDT added the c: feature Request for new feature label Feb 22, 2022
@ST-DDT ST-DDT added this to the v6.1 - First bugfixes milestone Feb 22, 2022
ST-DDT
ST-DDT previously approved these changes Feb 22, 2022
View reviewed changes
@codecov
Copy link

codecov bot commented Feb 22, 2022 •
edited
Loading

Codecov Report

Merging #543 (fd6c20f) into main (af3f99e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head fd6c20f differs from pull request most recent head 225e760. Consider uploading reports for the commit 225e760 to get more accurate results

@@           Coverage Diff           @@
##             main     #543   +/-   ##
=======================================
  Coverage   99.33%   99.33%           
=======================================
  Files        1920     1920           
  Lines      176483   176495   +12     
  Branches      905      905           
=======================================
+ Hits       175303   175315   +12     
  Misses       1124     1124           
  Partials       56       56
Impacted Files Coverage Δ
src/helpers.ts 99.12% <100.00%> (+0.01%) ⬆️

@ST-DDT ST-DDT requested a review from a team February 22, 2022 19:06
@ST-DDT ST-DDT changed the title chore: ceprecate helpers.*Card methods chore: deprecate helpers.*Card methods Feb 22, 2022
prisis
prisis previously approved these changes Feb 22, 2022
View reviewed changes
Shinigami92
Shinigami92 requested changes Mar 10, 2022
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add also tests to check that the warning is logged out?
You could orient yourself on tests for random module.

@sprohaszka sprohaszka dismissed stale reviews from prisis and ST-DDT via 96279e3 March 11, 2022 10:15
@sprohaszka sprohaszka force-pushed the fix/528-depecrate-card-methods branch from 4b31a36 to 96279e3 Compare March 11, 2022 10:15
@sprohaszka sprohaszka requested a review from Shinigami92 March 11, 2022 10:23
Shinigami92
Shinigami92 previously approved these changes Mar 11, 2022
View reviewed changes
@Shinigami92 Shinigami92 requested review from ST-DDT, prisis and a team March 11, 2022 12:01
ST-DDT
ST-DDT previously approved these changes Mar 11, 2022
View reviewed changes
@ST-DDT ST-DDT requested a review from a team March 11, 2022 18:59
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs and removed c: feature Request for new feature labels Mar 15, 2022
@ST-DDT ST-DDT force-pushed the fix/528-depecrate-card-methods branch from 96279e3 to fd6c20f Compare March 21, 2022 10:01
@Shinigami92 Shinigami92 enabled auto-merge (squash) March 21, 2022 12:39
@ST-DDT ST-DDT requested a review from a team March 21, 2022 12:39
@Shinigami92 Shinigami92 merged commit 1327b23 into faker-js:main Mar 21, 2022
@Shinigami92 Shinigami92 linked an issue Mar 23, 2022 that may be closed by this pull request
Deprecate helpers.userCard/contextualCard/createCard #528
Closed
@andrecastelo andrecastelo mentioned this pull request May 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@prisis prisis Awaiting requested review from prisis

Assignees

@sprohaszka sprohaszka

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent
Projects
None yet
Milestone
v6.1 - First bugfixes
Development

Successfully merging this pull request may close these issues.

Deprecate helpers.userCard/contextualCard/createCard
4 participants
@sprohaszka @ST-DDT @prisis @Shinigami92