Skip to content

chore: enable jsdoc/sort-tags #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 19, 2022
Merged

chore: enable jsdoc/sort-tags #512

merged 4 commits into from
Feb 19, 2022

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added the c: chore PR that doesn't affect the runtime behavior label Feb 19, 2022
@Shinigami92 Shinigami92 self-assigned this Feb 19, 2022
@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #512 (8b689da) into main (431c108) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 8b689da differs from pull request most recent head d02dc47. Consider uploading reports for the commit d02dc47 to get more accurate results

@@            Coverage Diff             @@
##             main     #512      +/-   ##
==========================================
- Coverage   99.34%   99.34%   -0.01%     
==========================================
  Files        1919     1919              
  Lines      176333   176294      -39     
  Branches      903      903              
==========================================
- Hits       175176   175137      -39     
  Misses       1101     1101              
  Partials       56       56              
Impacted Files Coverage Δ
src/helpers.ts 99.54% <ø> (-0.01%) ⬇️
src/image_providers/lorempixel.ts 92.83% <ø> (-0.42%) ⬇️
src/address.ts 98.70% <100.00%> (ø)
src/company.ts 100.00% <100.00%> (ø)
src/date.ts 100.00% <100.00%> (ø)
src/finance.ts 99.33% <100.00%> (ø)
src/git.ts 100.00% <100.00%> (ø)
src/image_providers/lorempicsum.ts 94.82% <100.00%> (-0.45%) ⬇️
src/image_providers/unsplash.ts 99.33% <100.00%> (-0.05%) ⬇️
src/name.ts 95.82% <100.00%> (ø)
... and 2 more

@Shinigami92 Shinigami92 force-pushed the lint-enable-jsdoc-sort-tags branch from 7411ec0 to 38dce0a Compare February 19, 2022 11:20
@Shinigami92 Shinigami92 marked this pull request as ready for review February 19, 2022 11:20
@Shinigami92 Shinigami92 requested a review from a team as a code owner February 19, 2022 11:20
@ST-DDT ST-DDT requested a review from a team February 19, 2022 12:11
@ST-DDT
Copy link
Member

ST-DDT commented Feb 19, 2022

FFR: We expect the following order of tags: https://github.com/gajus/eslint-plugin-jsdoc/blob/master/src/defaultTagOrder.js

Copy link
Contributor

@prisis prisis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the example comments

@ST-DDT ST-DDT merged commit b5d3cbf into main Feb 19, 2022
@ST-DDT ST-DDT deleted the lint-enable-jsdoc-sort-tags branch February 19, 2022 21:47
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants