Skip to content

fix(docs): faker.image.url should be under cloudflare ipfs #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 8, 2022
Merged

fix(docs): faker.image.url should be under cloudflare ipfs #454

merged 5 commits into from
Feb 8, 2022

Conversation

fzn0x
Copy link
Contributor

@fzn0x fzn0x commented Feb 8, 2022

rel: 5b3deb4

Also fix undefined image from amazon s3

@fzn0x fzn0x requested a review from a team as a code owner February 8, 2022 15:37
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #454 (4a9544d) into main (929f10e) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #454      +/-   ##
==========================================
- Coverage   99.32%   99.32%   -0.01%     
==========================================
  Files        1920     1920              
  Lines      174214   174214              
  Branches      895      893       -2     
==========================================
- Hits       173043   173041       -2     
- Misses       1115     1117       +2     
  Partials       56       56              
Impacted Files Coverage Δ
src/vendor/unique.ts 95.86% <0.00%> (-1.66%) ⬇️

@Shinigami92 Shinigami92 added the c: docs Improvements or additions to documentation label Feb 8, 2022
@Shinigami92 Shinigami92 requested a review from a team February 8, 2022 17:33
@ST-DDT ST-DDT requested a review from a team February 8, 2022 17:49
@ejcheng ejcheng added the c: chore PR that doesn't affect the runtime behavior label Feb 8, 2022
@ST-DDT ST-DDT merged commit f059509 into faker-js:main Feb 8, 2022
@fzn0x fzn0x deleted the patch-1 branch February 9, 2022 03:50
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior c: docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants