Skip to content

test: rewrite image tests #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 10, 2022
Merged

test: rewrite image tests #414

merged 5 commits into from
Feb 10, 2022

Conversation

Shinigami92
Copy link
Member

The tests actually looking good 🙂
We can leave them for now as is, I just did some formatting and variable naming stuff

@Shinigami92 Shinigami92 requested a review from a team as a code owner February 3, 2022 19:12
@Shinigami92 Shinigami92 self-assigned this Feb 3, 2022
@Shinigami92 Shinigami92 mentioned this pull request Feb 3, 2022
Closed
ST-DDT
ST-DDT requested changes Feb 3, 2022
View reviewed changes
@Shinigami92 Shinigami92 requested review from ST-DDT and a team February 4, 2022 18:16
ST-DDT
ST-DDT previously approved these changes Feb 4, 2022
View reviewed changes
@Shinigami92 Shinigami92 requested a review from a team February 4, 2022 18:41
@codecov
Copy link

codecov bot commented Feb 4, 2022 •
edited
Loading

Codecov Report

Merging #414 (3c5252d) into main (9edff1c) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 3c5252d differs from pull request most recent head 41796b6. Consider uploading reports for the commit 41796b6 to get more accurate results

@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
- Coverage   99.33%   99.32%   -0.01%     
==========================================
  Files        1920     1920              
  Lines      174319   174272      -47     
  Branches      898      895       -3     
==========================================
- Hits       173162   173101      -61     
- Misses       1101     1115      +14     
  Partials       56       56
Impacted Files Coverage Δ
src/vendor/user-agent.ts 93.82% <0.00%> (-3.66%) ⬇️
src/helpers.ts 99.30% <0.00%> (-0.18%) ⬇️
src/random.ts 99.51% <0.00%> (-0.05%) ⬇️

ST-DDT
ST-DDT previously approved these changes Feb 4, 2022
View reviewed changes
@ST-DDT ST-DDT requested a review from a team February 4, 2022 23:39
@ST-DDT ST-DDT added the needs rebase There is a merge conflict label Feb 6, 2022
@Shinigami92 Shinigami92 removed the needs rebase There is a merge conflict label Feb 6, 2022
@Shinigami92 Shinigami92 requested a review from ST-DDT February 6, 2022 12:28
ST-DDT
ST-DDT previously approved these changes Feb 6, 2022
View reviewed changes
@Shinigami92 Shinigami92 requested a review from a team February 6, 2022 13:39
@Shinigami92 Shinigami92 requested a review from ST-DDT February 10, 2022 18:08
@Shinigami92 Shinigami92 merged commit 2804886 into main Feb 10, 2022
@Shinigami92 Shinigami92 deleted the test-image-rewrite branch February 10, 2022 20:19
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
@Shinigami92 @demipel8
test: rewrite image tests (faker-js#414)
3e482a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@prisis prisis prisis approved these changes

@ejcheng ejcheng ejcheng approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: test
Projects
None yet
Milestone
v6.0 - Ensure Project Foundation
Development

Successfully merging this pull request may close these issues.
4 participants
@Shinigami92 @ST-DDT @prisis @ejcheng