-
-
Notifications
You must be signed in to change notification settings - Fork 975
chore: improve typings on random.objectElement #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Shinigami92
merged 8 commits into
faker-js:main
from
pkuczynski:random-object-element-type
Feb 3, 2022
Merged
chore: improve typings on random.objectElement #407
Shinigami92
merged 8 commits into
faker-js:main
from
pkuczynski:random-object-element-type
Feb 3, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@pkuczynski could you try: objectElement<T extends Record<string, unknown>, K extends keyof T>(
object: T,
field: 'key'
): K;
objectElement<T extends Record<string, unknown>, K extends keyof T>(
object: T,
field?: unknown
): T[K];
objectElement<T extends Record<string, unknown>, K extends keyof T>(
object = { foo: 'bar', too: 'car' } as unknown as T,
field = 'value'
): K | T[K] {
const array: Array<keyof T> = Object.keys(object);
const key = this.faker.random.arrayElement(array);
return field === 'key' ? (key as K) : (object[key] as T[K]);
} |
Shinigami92
reviewed
Feb 3, 2022
… random-object-element-type
Shinigami92
approved these changes
Feb 3, 2022
ST-DDT
approved these changes
Feb 3, 2022
Wouldn't it be much easier from an architectural and types perspective, by splitting this method into 2 separate ones? One for object value and one for object key. |
demipel8
pushed a commit
to demipel8/faker
that referenced
this pull request
Mar 11, 2022
Co-authored-by: Shinigami <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.