-
-
Notifications
You must be signed in to change notification settings - Fork 975
chore: enable eslint cache #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This works really nice. Where does it store the cache if I want to delete it? |
Root of the project. Its already gitignored. |
Codecov Report
@@ Coverage Diff @@
## main #403 +/- ##
=======================================
Coverage 99.32% 99.32%
=======================================
Files 1920 1920
Lines 174272 174272
Branches 893 893
=======================================
+ Hits 173099 173100 +1
+ Misses 1117 1116 -1
Partials 56 56
|
7edee34
to
3ee6f12
Compare
Tested it locally and seems to work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we encounter any problems in the future, we can revert it
@pkuczynski uhm... sry, but So maybe we should really add it to the |
Is it based on the content of the file itself? |
I honestly never had a problem with that :) And I keep my dependencies up to date on a weekly basis. In the worse case scenario CI would caught the issue as it does not have the cache enabled |
Okay 👍 |
We await approval from @prisis (or a third maintainer) |
This significantly speeds up subsequent eslint runs