Skip to content

chore: use explicit-module-boundary-types #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 30, 2022
Merged

chore: use explicit-module-boundary-types #361

merged 5 commits into from
Jan 30, 2022

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Jan 29, 2022 •
edited
Loading

@Shinigami92 Shinigami92 added the c: chore PR that doesn't affect the runtime behavior label Jan 29, 2022
@Shinigami92 Shinigami92 added this to the v6.0 - Project stability milestone Jan 29, 2022
@Shinigami92 Shinigami92 self-assigned this Jan 29, 2022
@Shinigami92 Shinigami92 requested a review from a team as a code owner January 29, 2022 19:13
ST-DDT
ST-DDT previously approved these changes Jan 29, 2022
View reviewed changes
@ST-DDT ST-DDT requested a review from a team January 29, 2022 20:28
@ST-DDT
Copy link
Member

ST-DDT commented Jan 29, 2022

Partial duplicate of #358

prisis
prisis previously approved these changes Jan 30, 2022
View reviewed changes
@ST-DDT ST-DDT added the needs rebase There is a merge conflict label Jan 30, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Jan 30, 2022

This needs to be rebased.

@Shinigami92 Shinigami92 dismissed stale reviews from prisis and ST-DDT via 37a2ef2 January 30, 2022 10:27
@Shinigami92 Shinigami92 force-pushed the explicit-module-boundary-types branch from dca354a to 37a2ef2 Compare January 30, 2022 10:27
@Shinigami92 Shinigami92 removed the needs rebase There is a merge conflict label Jan 30, 2022
ST-DDT
ST-DDT previously approved these changes Jan 30, 2022
View reviewed changes
@Shinigami92 Shinigami92 requested review from prisis and a team January 30, 2022 10:35
ejcheng
ejcheng previously approved these changes Jan 30, 2022
View reviewed changes
griest024
griest024 previously requested changes Jan 30, 2022
View reviewed changes
@Shinigami92 Shinigami92 requested a review from griest024 January 30, 2022 17:00
@Shinigami92 Shinigami92 dismissed griest024’s stale review January 30, 2022 17:01

this was just an alias

@Shinigami92 Shinigami92 dismissed stale reviews from ejcheng and ST-DDT via 2cf57a3 January 30, 2022 17:43
@Shinigami92 Shinigami92 requested a review from griest024 January 30, 2022 17:44
@Shinigami92 Shinigami92 requested a review from ST-DDT January 30, 2022 17:44
@Shinigami92 Shinigami92 merged commit d4125e2 into main Jan 30, 2022
@Shinigami92 Shinigami92 deleted the explicit-module-boundary-types branch January 30, 2022 17:55
bmenant pushed a commit to bmenant/faker that referenced this pull request Mar 11, 2022
@Shinigami92 @bmenant
chore: use explicit-module-boundary-types (faker-js#361)
b3e7004
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
@Shinigami92 @demipel8
chore: use explicit-module-boundary-types (faker-js#361)
dc7c479
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
@Shinigami92 @demipel8
chore: use explicit-module-boundary-types (faker-js#361)
c6070e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@ejcheng ejcheng ejcheng approved these changes

@prisis prisis Awaiting requested review from prisis

@griest024 griest024 Awaiting requested review from griest024

Assignees

@Shinigami92 Shinigami92

Labels
c: chore PR that doesn't affect the runtime behavior
Projects
None yet
Milestone
v6.0 - Ensure Project Foundation
Development

Successfully merging this pull request may close these issues.
5 participants
@Shinigami92 @ST-DDT @prisis @griest024 @ejcheng