-
-
Notifications
You must be signed in to change notification settings - Fork 974
refactor(locale): rename pt-BR streetSuffix to streetPrefix #3493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(locale): rename pt-BR streetSuffix to streetPrefix #3493
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3493 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 2876 2876
Lines 220587 220587
Branches 951 949 -2
=======================================
+ Hits 220532 220534 +2
+ Misses 55 53 -2
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
For other reviewers:
- Current "Suffix" File
- Wikipedia - List of Streets Brazil (helped me verify the change)
Thank you for your contribution @glmchalita.
|
|
What’s changed
Renamed
streetSuffix
→streetPrefix
in the PT-BR locale data and updated all related code and tests.Why
In Brazilian addresses, the street type (e.g. “Rua”, “Avenida”) always appears before the street name (for example, “Rua das Flores”). Calling it a “prefix” better reflects how our PT-BR formatting actually works.