Skip to content

feat(locale): update Japanese company categories #3489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025

Conversation

noritaka1166
Copy link
Contributor

Added Japanese company categories.

@noritaka1166 noritaka1166 requested a review from a team as a code owner April 26, 2025 12:22
Copy link

netlify bot commented Apr 26, 2025

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2ed6db7
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/681113db7704890008b665f2
😎 Deploy Preview https://deploy-preview-3489.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (dfadb1d) to head (2ed6db7).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3489   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2872     2872           
  Lines      219853   219865   +12     
  Branches      951      950    -1     
=======================================
+ Hits       219800   219812   +12     
  Misses         53       53           
Files with missing lines Coverage Δ
src/locales/ja/company/category.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Shinigami92
Shinigami92 previously approved these changes Apr 28, 2025
matthewmayer
matthewmayer previously approved these changes Apr 28, 2025
@xDivisionByZerox xDivisionByZerox added this to the v9.x milestone Apr 29, 2025
@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: company Something is referring to the company module labels Apr 29, 2025
@xDivisionByZerox
Copy link
Member

@noritaka1166 Could you resolve the merge conflict in this PR next? Thank you.

@noritaka1166 noritaka1166 dismissed stale reviews from matthewmayer and Shinigami92 via 2ed6db7 April 29, 2025 18:00
@noritaka1166
Copy link
Contributor Author

@noritaka1166 Could you resolve the merge conflict in this PR next? Thank you.

@xDivisionByZerox
I resolved it.

@xDivisionByZerox xDivisionByZerox merged commit 8c0953a into faker-js:next Apr 29, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: company Something is referring to the company module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants