Skip to content

refactor(locale): ko state data update #3487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025

Conversation

seoahan
Copy link
Contributor

@seoahan seoahan commented Apr 21, 2025

Split state changes from street changes PR as requested.

Expanded state names to their full names in state.ts .

@seoahan seoahan requested a review from a team as a code owner April 21, 2025 07:09
Copy link

netlify bot commented Apr 21, 2025

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 8c5a0e4
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/680a5e4135d8ae0008e6194e
😎 Deploy Preview https://deploy-preview-3487.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (38ee7b8) to head (8c5a0e4).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3487   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2859     2859           
  Lines      219518   219518           
  Branches      951      952    +1     
=======================================
+ Hits       219463   219465    +2     
+ Misses         55       53    -2     
Files with missing lines Coverage Δ
src/locales/ko/location/state.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module labels Apr 21, 2025
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Apr 21, 2025
@xDivisionByZerox xDivisionByZerox changed the title feat(locale): ko state data update refactor(locale): ko state data update Apr 21, 2025
@xDivisionByZerox xDivisionByZerox added the c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs label Apr 21, 2025
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks good. Although, I noticed that all the states are from south Korea only (as they where before). Technically, the locale ko is not bound to south Korea specifically, but all koran speaking countries. We might need to revisit this in the future and introduce a ko_KR locale. That way the locale data would more accurately describe its semantic definition.
Since the entries did exist before this change was proposed, I don't see the necessity to do this immediately.

@xDivisionByZerox xDivisionByZerox requested a review from a team April 22, 2025 12:00
@matthewmayer
Copy link
Contributor

The change itself looks good. Although, I noticed that all the states are from south Korea only (as they where before). Technically, the locale ko is not bound to south Korea specifically, but all koran speaking countries. We might need to revisit this in the future and introduce a ko_KR locale. That way the locale data would more accurately describe its semantic definition.

Since the entries did exist before this change was proposed, I don't see the necessity to do this immediately.

That is also the case for a bunch of other locales like fr and ru and jp and de. So I agree that's a fight for another day 😀

@xDivisionByZerox xDivisionByZerox merged commit b611ec2 into faker-js:next Apr 24, 2025
23 checks passed
@xDivisionByZerox
Copy link
Member

Thank you for your contribution @seoahan.
I see that this was your first contribution to our project (that got merged).
Would you mind answering some questions regarding your contribution? This way we can understand the potential struggles or confusions new contributors might have when getting into the project. If you don't want to answer, please ignore this comment:

  1. What did motivate you to do your contribution?
  2. Did you read our documentation regarding contributing before starting to work on your contribution?
  3. How clear was the process of working on your contribution (before the PR) for you? Was there ever a time while working in the project where you didn't know what to do? If so how did you solve your problem?
  4. How clear was the process of the code review (PR) for you? Was there ever a time you felt unsure about the current situation?
  5. Anything else you'd like to share with the Faker team?

@xDivisionByZerox xDivisionByZerox modified the milestones: vAnytime, v9.x May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: location Something is referring to the location module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants