-
-
Notifications
You must be signed in to change notification settings - Fork 973
feat(locale): add country code for en_CA & fr_CA #3476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(locale): add country code for en_CA & fr_CA #3476
Conversation
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3476 +/- ##
==========================================
- Coverage 99.97% 99.97% -0.01%
==========================================
Files 2836 2838 +2
Lines 218600 218606 +6
Branches 952 949 -3
==========================================
+ Hits 218547 218551 +4
- Misses 53 55 +2
🚀 New features to boost your workflow:
|
Thank you for your contribution @alixlahuec 🙏❤️.
|
@xDivisionByZerox Sure, I'd be happy to!
My team uses Faker to easily generate test data, we're Canada-based and recently came across some use cases where the locale we used with Faker mattered (we'd been using just
Yes ✅
It was pretty clear overall, I think there's a few points where I wasn't sure and checked previous contributions / ran commands to be confident I'd done what was needed:
Super clear (super fast!) 💯 I wasn't too sure how the Faker team organizes releases (what goes into what) but I wasn't worried about it!
Thanks for your work! We love using Faker, and I'll be happy to contribute back to the project when I can |
Thank you for your feedback. It's awesome to see that you were using the documentation preview to validate your changes - very creative.
I guess that you might be interested when you will actually be able to use your changes. The faker team tries to do monthly minor releases at the start of a month. So you should able to make your of your changes in Faker v9.8.0 in about 3 weeks. 🙂 |
Description
Configure
country_code
for theen_CA
andfr_CA
locales.Checklist
✅ I've ran
pnpm run preflight
✅ I've read https://github.com/faker-js/faker/blob/next/CONTRIBUTING.md