-
-
Notifications
You must be signed in to change notification settings - Fork 975
feat(locale): add Tamil language support #3468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We ask in the initial PR for a new locale that you only include basic metadata, plus a single module of locale data (e.g.
date
) - that makes it easier to review. You can then follow up with additional PRs once approved - Given for example the city list includes only Indian cities and the phone numbers start +91, this should probably be ta_IN as Tamil is also spoken in e.g. Sri Lanka and Singapore.
- The script code in metadata should be from https://en.wikipedia.org/wiki/ISO_15924 ie
Taml
notTamil
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3468 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 2819 2825 +6
Lines 217500 217571 +71
Branches 953 953
=======================================
+ Hits 217445 217518 +73
+ Misses 55 53 -2
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please allow a few days for the maintainers to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. I'll merge this PR, so feel free to contribute the other modules you initially provided as well. Remember, try to keep each PR to one module. This helps us in the review process as well as you and the community since your will PRs will get merged faster. 🙂
@Pradeepg2445 I see that this is your first contribution to our project.
|
Thank you so much for the warm message. It really means a lot to me as a first-time contributor ✨. What motivated me: Did I read the docs: Before the PR: When I was stuck: Code review: Anything else: |
Added Tamil (ta) localization support including translations for address, person, and internet modules.
pnpm run preflight
passed