Skip to content

feat(locale): add Tamil language support #3468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 10, 2025

Conversation

Pradeepg2445
Copy link
Contributor

Added Tamil (ta) localization support including translations for address, person, and internet modules.

  • Ensured format consistency with existing locales
  • Followed structure used in other language files
  • pnpm run preflight passed

@Pradeepg2445 Pradeepg2445 requested a review from a team as a code owner April 6, 2025 13:08
Copy link

netlify bot commented Apr 6, 2025

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit dfe2853
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/67f805c0870f7500087104ca
😎 Deploy Preview https://deploy-preview-3468.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@matthewmayer matthewmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We ask in the initial PR for a new locale that you only include basic metadata, plus a single module of locale data (e.g. date) - that makes it easier to review. You can then follow up with additional PRs once approved
  2. Given for example the city list includes only Indian cities and the phone numbers start +91, this should probably be ta_IN as Tamil is also spoken in e.g. Sri Lanka and Singapore.
  3. The script code in metadata should be from https://en.wikipedia.org/wiki/ISO_15924 ie Taml not Tamil

Copy link

codecov bot commented Apr 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (e2efa60) to head (dfe2853).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3468   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2819     2825    +6     
  Lines      217500   217571   +71     
  Branches      953      953           
=======================================
+ Hits       217445   217518   +73     
+ Misses         55       53    -2     
Files with missing lines Coverage Δ
src/locale/index.ts 100.00% <100.00%> (ø)
src/locale/ta_IN.ts 100.00% <100.00%> (ø)
src/locales/index.ts 100.00% <100.00%> (ø)
src/locales/ta_IN/date/index.ts 100.00% <100.00%> (ø)
src/locales/ta_IN/date/month.ts 100.00% <100.00%> (ø)
src/locales/ta_IN/date/weekday.ts 100.00% <100.00%> (ø)
src/locales/ta_IN/index.ts 100.00% <100.00%> (ø)
src/locales/ta_IN/metadata.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@matthewmayer matthewmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please allow a few days for the maintainers to review.

@xDivisionByZerox xDivisionByZerox added c: feature Request for new feature p: 1-normal Nothing urgent c: locale Permutes locale definitions m: date Something is referring to the date module labels Apr 10, 2025
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Apr 10, 2025
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. I'll merge this PR, so feel free to contribute the other modules you initially provided as well. Remember, try to keep each PR to one module. This helps us in the review process as well as you and the community since your will PRs will get merged faster. 🙂

@xDivisionByZerox xDivisionByZerox merged commit cdf6dc4 into faker-js:next Apr 10, 2025
36 of 37 checks passed
@xDivisionByZerox
Copy link
Member

xDivisionByZerox commented Apr 10, 2025

@Pradeepg2445 I see that this is your first contribution to our project.
Would you mind answering some questions regarding your contribution? This way we can understand the potential struggles or confusions new contributors might have when getting into the project. If you don't want to answer, please ignore this comment:

  1. What did motivate you to do your contribution?
  2. Did you read our documentation regarding contributing before starting to work on your contribution?
  3. How clear was the process of working on your contribution (before the PR) for you? Was there ever a time while working in the project where you didn't know what to do? If so how did you solve your problem?
  4. How clear was the process of the code review (PR) for you? Was there ever a time you felt unsure about the current situation?
  5. Anything else you'd like to share with the Faker team?

@Pradeepg2445
Copy link
Contributor Author

Pradeepg2445 commented Apr 12, 2025

Hi @xDivisionByZerox,

Thank you so much for the warm message. It really means a lot to me as a first-time contributor ✨.

What motivated me:
I’ve used Faker in many of my projects, and it has always been helpful. I just wanted to give something back to a project that helped me so much.

Did I read the docs:
Yes, I read the contributing documentation before starting. It was clear and gave me good guidance.

Before the PR:
The process was mostly clear. There were a few moments where I had to spend extra time understanding the codebase, but I enjoyed learning through it.

When I was stuck:
Yes, there was a moment where I wasn’t sure how to structure a part of the code. I looked at existing files and previous PRs, and that helped me find a way.

Code review:
The review was kind and helpful. It made me feel comfortable and supported.

Anything else:
Just a big thank you. I’m really happy to be part of this. I hope to keep contributing and learning with you all 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature c: locale Permutes locale definitions m: date Something is referring to the date module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants