chore: rename phone_number to phone #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The same thing should possibly happen to locales. Let me know if I should do it (in this or separate PR) |
|
Where were not sure right now if the |
Shinigami92
modified the milestones:
v6.0 - Project stability,
v6 - Can be worked on in parallel
|
https://github.com/faker-js/faker/blob/main/test/fake.spec.ts#L7 and the class itself is using definitions in this way: https://github.com/faker-js/faker/blob/main/src/phone_number.ts#L36 So I think its pretty safe change and its always good to verify via tests... |
ST-DDT
approved these changes
Jan 28, 2022
prisis
approved these changes
Jan 29, 2022
ejcheng
approved these changes
Jan 29, 2022
bmenant
pushed a commit
to bmenant/faker
that referenced
this pull request
Mar 11, 2022
demipel8
pushed a commit
to demipel8/faker
that referenced
this pull request
Mar 11, 2022
demipel8
pushed a commit
to demipel8/faker
that referenced
this pull request
Mar 11, 2022
ST-DDT
modified the milestones:
v6 - Non-Breaking Changes,
v6.0 - Ensure Project Foundation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every other file is named like the class, except this one:
I aligned this with other files and simply renamed this one to match the class name.