Skip to content

infra(ci): prepare CI for GitHub merge queues #3245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Nov 3, 2024

Updates the workflow files to contain triggers for merge queues.

(all files that have required checks, must be tagged with the merge_queue trigger)

This is my first attempt at this, so I'm not sure whether I configured this correctly.
Not sure how to test this, I cannot test this in my private fork of Faker (as merge queues seem to be an organization feature?).


Technical explanation about merge queues:

GitHub's merge queues are ways to merge PRs in rapid succession without omitting CI tests.

  • PRs that gets added to the queue are synced to the target branch,
  • the CI is triggered
    • and if successful, the PR is merged
    • if not successful, the PR is removed from the merge queue
  • The next PR from the merge queue is processed

Documentation


At this point in time I'm not sure whether we should use merge queues, but I would like to enable them to gain some experience in their utility. If you have some insides into them, please let me know.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Nov 3, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Nov 3, 2024
@ST-DDT ST-DDT requested review from a team November 3, 2024 22:02
@ST-DDT ST-DDT self-assigned this Nov 3, 2024
Copy link

netlify bot commented Nov 3, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 327c639
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/672a8780371bf9000823ce32
😎 Deploy Preview https://deploy-preview-3245.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (df87d60) to head (327c639).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3245      +/-   ##
==========================================
- Coverage   99.97%   99.96%   -0.01%     
==========================================
  Files        2805     2805              
  Lines      217098   217098              
  Branches      973      966       -7     
==========================================
- Hits       217034   217018      -16     
- Misses         64       80      +16     

see 1 file with indirect coverage changes

@ST-DDT ST-DDT requested a review from a team November 4, 2024 08:10
@ST-DDT ST-DDT merged commit 69173a3 into next Nov 6, 2024
23 checks passed
@ST-DDT ST-DDT deleted the infra/github/merge_queue branch November 6, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants