-
-
Notifications
You must be signed in to change notification settings - Fork 975
docs: automatically generate api docs from source #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: automatically generate api docs from source #289
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled it down and tried it. I love this. I think we could make the parameters a little prettier, but this is so much better than what exists, I think we should merge it now.
I feel a little awkward about committing generated source code... I think we should probably have CI re-build and publish the docs instead of committing them.
BUT! Regardless, I believe it is a good first step ❤️
Yes, same. I think we shouldn't commit that, otherwise the CI will create changes in the repo files, which is not good. |
This looks great! Can we have the sidenav automatically generated when looping on the modules maybe? IIRC we can use Frontmatter for that? Or simply generate a Javascript array that is then processed in the |
I will do that.
My original idea was to attach it to a pre commit hook, but on the fly generation is probably best.
Any suggestion how it should look like? |
I would only generate the code in the ci if the docs are build, so there is always up to date version live and put the docs/api to gitignore |
Also we have to do it like that, otherwise it could be hard to setup a CI that especially bypasses admin privileges to push into main branch |
Yeah, build it on CI and .gitignore the local files. @ST-DDT I was looking for inspo when I did this PR review earlier... I think Styleguidist has a decent UI |
What are your thoughts about localization support for that? #196 |
@JessicaSachs Like this? I changed the command to manually generate the files to |
Co-authored-by: Shinigami <[email protected]>
I will approve that now, but we should document
|
Co-authored-by: Shinigami <[email protected]>
Co-authored-by: Shinigami <[email protected]>
Co-authored-by: Shinigami <[email protected]>
Automatically generates the api documentation using typedocs.
Based on PR #207 by @ericjeker