Skip to content

fix: change random.word to be based on definitions.word.* #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

fix: change random.word to be based on definitions.word.* #276

Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c9e993a
fix: change random.word to be based on definitions.word.*
pkuczynski Jan 23, 2022
5b5c566
Update random.ts
pkuczynski Jan 24, 2022
6087ada
Update random.ts
pkuczynski Jan 24, 2022
fc631d8
Merge branch 'main' into random-word
Shinigami92 Jan 30, 2022
5cc01ee
Merge branch 'main' into random-word
pkuczynski Feb 1, 2022
2dd3a1d
Merge branch 'main' into random-word
pkuczynski Mar 21, 2022
4a88034
Merge branch 'main' into random-word
pkuczynski Mar 21, 2022
a1e24a7
Merge remote-tracking branch 'origin/random-word' into random-word
pkuczynski Mar 21, 2022
84eac47
fix tests
pkuczynski Mar 21, 2022
7d38865
Merge branch 'main' into random-word
pkuczynski Mar 21, 2022
e377f18
fix test
pkuczynski Mar 21, 2022
3cc73ef
Merge branch 'main' into random-word
pkuczynski Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 11 additions & 43 deletions src/random.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,53 +159,21 @@ export class Random {
return this.faker.datatype.boolean();
}

// TODO: have ability to return specific type of word? As in: noun, adjective, verb, etc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question is if we want to have this feature too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have. Users can use faker.word.xyz to do it... That's why I removed this comment.

/**
* word
*
* @method faker.random.word
* @param type
* Returns random word.
*/
// TODO @Shinigami92 2022-01-11: `type` is not in use
word(type?: unknown): string {
const wordMethods = [
'commerce.department',
'commerce.productName',
'commerce.productAdjective',
'commerce.productMaterial',
'commerce.product',
'commerce.color',

'company.catchPhraseAdjective',
'company.catchPhraseDescriptor',
'company.catchPhraseNoun',
'company.bsAdjective',
'company.bsBuzz',
'company.bsNoun',
'address.streetSuffix',
'address.county',
'address.country',
'address.state',

'finance.accountName',
'finance.transactionType',
'finance.currencyName',

'hacker.noun',
'hacker.verb',
'hacker.adjective',
'hacker.ingverb',
'hacker.abbreviation',

'name.jobDescriptor',
'name.jobArea',
'name.jobType',
word(): string {
const generators = [
this.faker.word.adjective,
this.faker.word.adverb,
this.faker.word.conjunction,
this.faker.word.interjection,
this.faker.word.noun,
this.faker.word.preposition,
this.faker.word.verb,
];

// randomly pick from the many faker methods that can generate words
const randomWordMethod = this.faker.random.arrayElement(wordMethods);
const result = this.faker.fake('{{' + randomWordMethod + '}}');
return this.faker.random.arrayElement(result.split(' '));
return this.faker.random.arrayElement(generators)();
}

readonly randomWord: Random['word'] = this.word.bind(this);
Expand Down