Skip to content

chore: improve readability and type safety for loadDefinitions #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 28, 2022
Merged

chore: improve readability and type safety for loadDefinitions #269

merged 5 commits into from
Mar 28, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jan 23, 2022

No description provided.

@ST-DDT ST-DDT requested a review from a team as a code owner January 23, 2022 18:50
@Shinigami92 Shinigami92 added the c: chore PR that doesn't affect the runtime behavior label Jan 23, 2022
@Shinigami92
Copy link
Member

I would like to wait with this change until we are at least much more familiar with the test suite

Shinigami92
Shinigami92 reviewed Feb 1, 2022
View reviewed changes
@ST-DDT ST-DDT requested a review from Shinigami92 February 2, 2022 17:32
Shinigami92
Shinigami92 previously approved these changes Feb 3, 2022
View reviewed changes
@Shinigami92 Shinigami92 requested review from a team February 3, 2022 08:10
@codecov
Copy link

codecov bot commented Feb 6, 2022 •
edited
Loading

Codecov Report

Merging #269 (920f3bc) into main (0f74908) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 920f3bc differs from pull request most recent head ae358c8. Consider uploading reports for the commit ae358c8 to get more accurate results

@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
- Coverage   99.34%   99.34%   -0.01%     
==========================================
  Files        1923     1923              
  Lines      176903   176900       -3     
  Branches      900      901       +1     
==========================================
- Hits       175742   175739       -3     
  Misses       1105     1105              
  Partials       56       56
Impacted Files Coverage Δ
src/faker.ts 100.00% <100.00%> (ø)

@Shinigami92 Shinigami92 added the needs rebase There is a merge conflict label Mar 10, 2022
@Shinigami92
Copy link
Member

@ST-DDT This PR needs a rebase

@ST-DDT
Copy link
Member Author

ST-DDT commented Mar 10, 2022

Done

@ST-DDT ST-DDT removed the needs rebase There is a merge conflict label Mar 10, 2022
Shinigami92
Shinigami92 previously approved these changes Mar 11, 2022
View reviewed changes
@Shinigami92 Shinigami92 requested a review from a team March 11, 2022 12:10
@Shinigami92 Shinigami92 added the p: 1-normal Nothing urgent label Mar 15, 2022
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Mar 21, 2022
@ST-DDT ST-DDT requested a review from Shinigami92 March 21, 2022 13:48
Shinigami92
Shinigami92 previously approved these changes Mar 21, 2022
View reviewed changes
@ST-DDT ST-DDT requested a review from a team March 21, 2022 13:54
Shinigami92
Shinigami92 previously approved these changes Mar 22, 2022
View reviewed changes
@Shinigami92 Shinigami92 requested a review from a team March 22, 2022 15:01
Shinigami92
Shinigami92 previously approved these changes Mar 23, 2022
View reviewed changes
Shinigami92
Shinigami92 reviewed Mar 23, 2022
View reviewed changes
@ST-DDT ST-DDT requested a review from Shinigami92 March 24, 2022 10:05
Shinigami92
Shinigami92 previously approved these changes Mar 24, 2022
View reviewed changes
@Shinigami92 Shinigami92 requested a review from a team March 24, 2022 10:21
Shinigami92
Shinigami92 previously approved these changes Mar 24, 2022
View reviewed changes
@Shinigami92 Shinigami92 requested a review from a team March 24, 2022 10:37
@ST-DDT ST-DDT requested a review from a team March 25, 2022 12:57
@ST-DDT ST-DDT added needs rebase There is a merge conflict and removed needs rebase There is a merge conflict labels Mar 25, 2022
@ST-DDT ST-DDT changed the title chore: fix suppressed warning and add some content hints chore: improve readability and type safety for Faker.loadDefinitions() Mar 25, 2022
@ST-DDT ST-DDT requested a review from Shinigami92 March 25, 2022 23:14
Shinigami92
Shinigami92 previously approved these changes Mar 26, 2022
View reviewed changes
@Shinigami92 Shinigami92 requested a review from a team March 26, 2022 11:33
@Shinigami92 Shinigami92 added the needs rebase There is a merge conflict label Mar 28, 2022
@ST-DDT ST-DDT removed the needs rebase There is a merge conflict label Mar 28, 2022
@ST-DDT ST-DDT requested a review from Shinigami92 March 28, 2022 17:03
@Shinigami92 Shinigami92 changed the title chore: improve readability and type safety for Faker.loadDefinitions() chore: improve readability and type safety for loadDefinitions Mar 28, 2022
@Shinigami92 Shinigami92 enabled auto-merge (squash) March 28, 2022 17:06
@Shinigami92 Shinigami92 merged commit 94c96ba into faker-js:main Mar 28, 2022
@ST-DDT ST-DDT deleted the chore/fix-suppressed-warnings branch March 28, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@griest024 griest024 Awaiting requested review from griest024

Assignees

@ST-DDT ST-DDT

Labels
c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Milestone
v6.1 - First bugfixes
Development

Successfully merging this pull request may close these issues.
3 participants
@ST-DDT @Shinigami92 @xDivisionByZerox