Skip to content

chore: add .nvmrc for those who use automatic node switching #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 25, 2022
Merged

chore: add .nvmrc for those who use automatic node switching #267

merged 3 commits into from
Jan 25, 2022

Conversation

pkuczynski
Copy link
Member

@pkuczynski pkuczynski requested a review from a team as a code owner January 23, 2022 18:35
@ejcheng ejcheng added the c: chore PR that doesn't affect the runtime behavior label Jan 23, 2022
@pkuczynski pkuczynski mentioned this pull request Jan 23, 2022
Closed
prisis
prisis previously approved these changes Jan 23, 2022
View reviewed changes
@prisis prisis added this to the v6.0.0 - Project stability milestone Jan 23, 2022
@Shinigami92
Copy link
Member

Shinigami92 commented Jan 24, 2022 •
edited
Loading

Is it possible to give a version range? Or like >=16.9

16.9 first introduces corepack and this could be really helpful for using the compatibility npm to pnpm if you have activated it on your machine

@Shinigami92 Shinigami92 self-requested a review January 24, 2022 09:30
@pkuczynski
Copy link
Member Author

Is it possible to give a version range? Or like >=16.9

16.9 first introduces corepack and this could be really helpful for using the compatibility npm to pnpm if you have activated it on your machine

No, its not possible to specify a version like this. But we can do 16.9 which I just did. This will force to use 16.9 for anybody using avn (or similar automatic node switching).

@pkuczynski pkuczynski requested a review from prisis January 24, 2022 09:36
@Shinigami92
Copy link
Member

Okay, sorry than for that
I would vote then to force 16.13 (the current version) for now

@pkuczynski
Copy link
Member Author

We can use lts/gallium to express latest node 16 or lts/* for latest LTS. See https://github.com/nvm-sh/nvm#long-term-support. Let me know how should I adjust it?

@prisis
Copy link
Contributor

prisis commented Jan 24, 2022 •
edited
Loading

Okay, sorry than for that I would vote then to force 16.13 (the current version) for now

Than we need to change or add 16.13 to the ci too

@pkuczynski
Copy link
Member Author

Than we need to change or add 16.13 to the ci too

Should I do this as part of this PR?

@Shinigami92
Copy link
Member

Shinigami92 commented Jan 24, 2022 •
edited
Loading

Than we need to change or add 16.13 to the ci too

@prisis I think CI don't use nvm, does it?

The lts/gallium sounds also good to me 🤔

@pkuczynski
Copy link
Member Author

Than its ready to merge :)

@Shinigami92 Shinigami92 requested a review from a team January 24, 2022 19:34
@Shinigami92 Shinigami92 merged commit b258f4f into faker-js:main Jan 25, 2022
@pkuczynski pkuczynski deleted the nvmrc branch January 25, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@prisis prisis Awaiting requested review from prisis

Assignees

@pkuczynski pkuczynski

Labels
c: chore PR that doesn't affect the runtime behavior
Projects
None yet
Milestone
v6.0 - Ensure Project Foundation
Development

Successfully merging this pull request may close these issues.
5 participants
@pkuczynski @Shinigami92 @prisis @ST-DDT @ejcheng