fix(helpers): multiple update argument types #2636
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change users of
faker.helpers.multiple()
will know thatmethod
function may have access toindex
of current element.Use case: generator wants to know the index of element that it is generating.
This is not a breaking change, because it add argument types for already used code, any current code that is using this function will work without any changes/warnings. But in future it may lead to some difficulties with changing method signature or refactoring inner code (
Array.from
). There is a way to mitigate this issue but it requires to modifyArray.from
call will additional wrapper-function, that will negotiatemethod
definition with actual used code.pnpm run preflight
runs without errors.Usage example: