infra(typescript-eslint): prefer-regexp-exec #2466
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR for #2435. This applies the changes from #2108 to newer code and ensures future code abides to the same rules.
Enables the
@typescript-eslint/prefer-regexp-exec
lint rule.Reasoning:
Regexp.exec
behaves the same asstring.match(RegExp)
without/g
flag, with the main difference being that exec gurantees the index to be present:string.match(RegExp)
without/g
flag, also returns the index, but requires the not null assertion qualifier!
.