Skip to content

refactor(git): don't use Intl #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 14, 2023
Merged

refactor(git): don't use Intl #2222

merged 5 commits into from
Jul 14, 2023

Conversation

matthewmayer
Copy link
Contributor

fix #2221 ref #2171

Removes the use of Intl in faker.git.commitDate

@matthewmayer matthewmayer requested a review from a team as a code owner June 23, 2023 11:14
@matthewmayer matthewmayer mentioned this pull request Jun 23, 2023
Closed
10 tasks
@matthewmayer matthewmayer self-assigned this Jun 23, 2023
@matthewmayer matthewmayer added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: git Something is referring to the git module labels Jun 23, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023 •
edited
Loading

Codecov Report

Merging #2222 (2cb9173) into next (ee12c32) will decrease coverage by 0.01%.
The diff coverage is 99.56%.

❗ Current head 2cb9173 differs from pull request most recent head f96cdbb. Consider uploading reports for the commit f96cdbb to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2222      +/-   ##
==========================================
- Coverage   99.60%   99.60%   -0.01%     
==========================================
  Files        2639     2642       +3     
  Lines      245709   245777      +68     
  Branches     1155     1154       -1     
==========================================
+ Hits       244737   244804      +67     
- Misses        945      946       +1     
  Partials       27       27
Impacted Files Coverage Δ
src/definitions/color.ts 0.00% <0.00%> (ø)
src/faker.ts 92.05% <100.00%> (ø)
src/locales/en_GB/location/index.ts 100.00% <100.00%> (ø)
src/locales/en_GB/location/state.ts 100.00% <100.00%> (ø)
src/locales/en_GB/location/state_abbr.ts 100.00% <100.00%> (ø)
src/locales/nl/commerce/index.ts 100.00% <100.00%> (ø)
src/locales/nl/commerce/product_description.ts 100.00% <100.00%> (ø)
src/locales/nl/commerce/product_name.ts 100.00% <100.00%> (ø)
src/locales/nl/internet/domain_suffix.ts 100.00% <100.00%> (ø)
src/locales/nl/location/index.ts 100.00% <100.00%> (ø)
... and 12 more

... and 1 file with indirect coverage changes

xDivisionByZerox
xDivisionByZerox previously approved these changes Jul 1, 2023
View reviewed changes
ST-DDT
ST-DDT reviewed Jul 2, 2023
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it looks like I forgot to post these.

Shinigami92
Shinigami92 requested changes Jul 2, 2023
View reviewed changes
@ST-DDT ST-DDT enabled auto-merge (squash) July 14, 2023 20:00
@ST-DDT ST-DDT merged commit c6323f8 into faker-js:next Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox Awaiting requested review from xDivisionByZerox

Assignees

@matthewmayer matthewmayer

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: git Something is referring to the git module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

ReferenceError: Intl is not defined
4 participants
@matthewmayer @ST-DDT @Shinigami92 @xDivisionByZerox